Page MenuHomePhabricator

Support text encoding and syntax highlighting options in document rendering
ClosedPublic

Authored by epriestley on Mar 30 2018, 6:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 4:57 PM
Unknown Object (File)
Tue, Mar 5, 7:44 AM
Unknown Object (File)
Fri, Mar 1, 3:47 AM
Unknown Object (File)
Feb 21 2024, 11:36 AM
Unknown Object (File)
Feb 3 2024, 6:38 PM
Unknown Object (File)
Feb 3 2024, 6:38 PM
Unknown Object (File)
Feb 3 2024, 6:38 PM
Unknown Object (File)
Jan 26 2024, 1:02 PM
Subscribers
None

Details

Summary

Depends on D19273. Ref T13105. Adds "Change Text Encoding..." and "Highlight As..." options when rendering documents, and makes an effort to automatically detect and handle text encoding.

Test Plan
  • Uploaded a Shift-JIS file, saw it auto-detect as Shift-JIS.
  • Converted files between encodings.
  • Highlighted various things as "Rainbow", etc.

Diff Detail

Repository
rP Phabricator
Branch
doce2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19956
Build 27054: Run Core Tests
Build 27053: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 6:28 PM
This revision was automatically updated to reflect the committed changes.