Differential D19273

Make Jupyter notebooks use the fast builtin Python highlighter
ClosedPublic
Actions

Authored by epriestley on Mar 30 2018, 4:48 PM.

Tags

None

Referenced Files

	F18125088: D19273.id46136.diff
	Wed, Aug 13, 12:51 PM

	F18125087: D19273.id46134.diff
	Wed, Aug 13, 12:51 PM

	F18125085: D19273.id.diff
	Wed, Aug 13, 12:51 PM

	F18112191: D19273.diff
	Tue, Aug 12, 4:09 PM

	F18111831: D19273.diff
	Tue, Aug 12, 1:21 PM

	F18110823: D19273.diff
	Tue, Aug 12, 12:16 AM

	F18109035: D19273.diff
	Mon, Aug 11, 11:24 AM

	F18095030: D19273.id.diff
	Thu, Aug 7, 10:30 PM

View All Files

Subscribers

None

Details

Reviewers

mydeveloperday

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rPccbc8a430f62: Make Jupyter notebooks use the fast builtin Python highlighter

Summary

Ref T13105. This is silly, but "py" and "python" end up in different places today, and "py" is ~100x faster than "python".

See also T3626 for longer-term plans on this.

Test Plan

Reloaded a Jupyter notebook, saw it render almost instantly instead of taking a few seconds.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 30 2018, 4:48 PM

Harbormaster completed remote builds in B19955: Diff 46134.Mar 30 2018, 4:49 PM

epriestley requested review of this revision.Mar 30 2018, 4:49 PM

mydeveloperday accepted this revision.Mar 30 2018, 5:19 PM

This revision is now accepted and ready to land.Mar 30 2018, 5:19 PM

epriestley added a child revision: D19274: Support text encoding and syntax highlighting options in document rendering.Mar 30 2018, 6:15 PM

Closed by commit rPccbc8a430f62: Make Jupyter notebooks use the fast builtin Python highlighter (authored by epriestley). · Explain WhyMar 30 2018, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

document/

PhabricatorJupyterDocumentEngine.php

2 lines

Diff 46136

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Make Jupyter notebooks use the fast builtin Python highlighterClosedPublicActions