Differential D19265

Disable Herald and enormous change protection for repository initial imports
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 2:22 PM.

Details

Reviewers: None
Maniphest Tasks: T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them
T13114: Plans: 2018 Week 13 Bonus Content
Commits: rP74216ea8e008: Disable Herald and enormous change protection for repository initial imports

Summary

See PHI514. Ref T13114. Ref T8951. When a push is an "initial import" (a push of at least 7 commits to an empty repository) don't run Herald or enormous change protection.

Test Plan

Pushed some non-initial changes to a repository, and some initial changes.

Diff Detail

Repository

rP Phabricator

Branch

enorm1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19940
Build 27030: Run Core Tests
Build 27029: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 29 2018, 2:22 PM

Harbormaster completed remote builds in B19940: Diff 46118.Mar 29 2018, 2:23 PM

epriestley requested review of this revision.Mar 29 2018, 2:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 3:05 PM

Closed by commit rP74216ea8e008: Disable Herald and enormous change protection for repository initial imports (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19297: Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats.Apr 5 2018, 1:15 PM

epriestley mentioned this in rP3de002c8414a: Fix a commit hook issue where pushing dangerous changes would fatal before….Apr 5 2018, 1:19 PM

epriestley mentioned this in rP0fef964d86de: (stable) Fix a commit hook issue where pushing dangerous changes would fatal….

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

49 lines

Diff 46118

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Disable Herald and enormous change protection for repository initial importsClosedPublicActions