Page MenuHomePhabricator

Record lock timing information on PushEvents
ClosedPublic

Authored by epriestley on Mar 22 2018, 8:09 PM.
Tags
None
Referenced Files
F14000021: D19250.id46085.diff
Thu, Oct 24, 6:53 PM
F13973223: D19250.diff
Oct 17 2024, 11:48 PM
Unknown Object (File)
Oct 9 2024, 9:15 AM
Unknown Object (File)
Sep 20 2024, 6:43 AM
Unknown Object (File)
Sep 20 2024, 6:37 AM
Unknown Object (File)
Sep 20 2024, 6:37 AM
Unknown Object (File)
Sep 20 2024, 6:33 AM
Unknown Object (File)
Sep 10 2024, 11:56 PM
Subscribers
None

Details

Summary

Depends on D19249. Ref T13109. Add timing information to the PushEvent:

  • writeWait: Time spent waiting for a write lock.
  • readWait: Time spent waiting for a read lock.
  • hostWait: Roughly, total time spent on the leaf node.

The primary goal here is to see if readWait is meaningful in the wild. If it is, that motivates smarter routing, and the value of smarter routing can be demonstrated by looking for a reduction in read wait times.

Test Plan

Pushed some stuff, saw reasonable timing values in the table. Saw timing information in "Export Data".

Diff Detail

Repository
rP Phabricator
Branch
lock3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19903
Build 26978: Run Core Tests
Build 26977: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2018, 8:46 PM
This revision was automatically updated to reflect the committed changes.