Page MenuHomePhabricator

Skip loading file transform sources when we know a file is not transformed
ClosedPublic

Authored by epriestley on Mar 14 2018, 6:57 PM.
Tags
None
Referenced Files
F14417418: D19224.id46029.diff
Wed, Dec 25, 1:03 AM
F14413220: D19224.diff
Tue, Dec 24, 1:59 PM
Unknown Object (File)
Sun, Dec 15, 1:54 AM
Unknown Object (File)
Thu, Dec 12, 6:46 PM
Unknown Object (File)
Mon, Dec 2, 8:51 PM
Unknown Object (File)
Mon, Dec 2, 8:51 PM
Unknown Object (File)
Mon, Dec 2, 8:51 PM
Unknown Object (File)
Wed, Nov 27, 11:03 AM
Subscribers
None

Details

Summary

Depends on D19223. Ref T13106. When we're loading a file, we currently test if it's a transformed version of another file (usually, a thumbnail) and apply policy behavior if it is.

We know that builtins and profile images are never transforms and that the policy behavior for these files doesn't matter anyway. Skip loading transforms for these files.

Test Plan

Saw local queries drop from 146 to 139 with no change in behavior.

Diff Detail

Repository
rP Phabricator
Branch
perf5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/files/query/PhabricatorFileQuery.php:231XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19846
Build 26894: Run Core Tests
Build 26893: arc lint + arc unit