Page MenuHomePhabricator

Skip loading file transform sources when we know a file is not transformed
ClosedPublic

Authored by epriestley on Mar 14 2018, 6:57 PM.
Tags
None
Referenced Files
F17744498: D19224.diff
Mon, Jul 21, 4:10 PM
F17607974: D19224.diff
Wed, Jul 9, 4:19 AM
Unknown Object (File)
Tue, Jul 1, 11:58 AM
Unknown Object (File)
Mon, Jun 30, 2:47 AM
Unknown Object (File)
Sun, Jun 29, 8:43 AM
Unknown Object (File)
Jun 2 2025, 11:36 PM
Unknown Object (File)
May 31 2025, 8:06 PM
Unknown Object (File)
May 31 2025, 9:58 AM
Subscribers
None

Details

Summary

Depends on D19223. Ref T13106. When we're loading a file, we currently test if it's a transformed version of another file (usually, a thumbnail) and apply policy behavior if it is.

We know that builtins and profile images are never transforms and that the policy behavior for these files doesn't matter anyway. Skip loading transforms for these files.

Test Plan

Saw local queries drop from 146 to 139 with no change in behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable