Page MenuHomePhabricator

Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy
ClosedPublic

Authored by epriestley on Mar 13 2018, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 1:30 AM
Unknown Object (File)
Sat, Jan 25, 12:43 AM
Unknown Object (File)
Sat, Jan 25, 12:43 AM
Unknown Object (File)
Sat, Jan 25, 12:43 AM
Unknown Object (File)
Sat, Jan 25, 12:43 AM
Unknown Object (File)
Dec 29 2024, 9:05 PM
Unknown Object (File)
Dec 26 2024, 2:31 AM
Unknown Object (File)
Dec 13 2024, 8:32 AM
Subscribers
None

Details

Summary

See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors.

The new Content-Security-Policy prevents this from functioning.

Replace this with a more modern behavior-driven action instead.

Test Plan
  • Clicked some errors in DarkConsole, saw stack traces appear.
  • Grepped for onclick and jsprintf() to see if I could find any more of these, but came up empty.

Diff Detail

Repository
rP Phabricator
Branch
onclick1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19837
Build 26879: Run Core Tests
Build 26878: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 11:45 PM
This revision was automatically updated to reflect the committed changes.