Page MenuHomePhabricator
Differential D19218

Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy
ClosedPublic
Actions

Authored by epriestley on Mar 13 2018, 11:39 PM.
Tags
None
Referenced Files
F15414945: D19218.diff
Thu, Mar 20, 3:13 AM
F15375423: D19218.id.diff
Wed, Mar 12, 11:10 PM
F15335993: D19218.diff
Sat, Mar 8, 6:00 PM
Unknown Object (File)
Tue, Feb 25, 8:12 AM
Unknown Object (File)
Thu, Feb 20, 4:50 PM
Unknown Object (File)
Thu, Feb 20, 4:50 PM
Unknown Object (File)
Thu, Feb 20, 4:49 PM
Unknown Object (File)
Thu, Feb 20, 4:49 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13102: Plans: 2018 Week 11 Bonus Content
Commits
rPdc7e40ff3fc7: Fix the DarkConsole inline error log stack trace expansion behavior for Content…
Summary

See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors.

The new Content-Security-Policy prevents this from functioning.

Replace this with a more modern behavior-driven action instead.

Test Plan
  • Clicked some errors in DarkConsole, saw stack traces appear.
  • Grepped for onclick and jsprintf() to see if I could find any more of these, but came up empty.

Diff Detail

Repository
rP Phabricator
Branch
onclick1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19837
Build 26879: Run Core Tests
Build 26878: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 13 2018, 11:39 PM
Harbormaster completed remote builds in B19837: Diff 46020.Mar 13 2018, 11:40 PM
epriestley requested review of this revision.Mar 13 2018, 11:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 11:45 PM
Closed by commit rPdc7e40ff3fc7: Fix the DarkConsole inline error log stack trace expansion behavior for Content… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
34 lines
4 lines
src/
applications/
console/
plugin/
7 lines
view/
page/
3 lines
webroot/
rsrc/
js/
core/
darkconsole/
20 lines

Diff 46020

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/console/plugin/DarkConsoleErrorLogPlugin.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-error-log.js

Loading...
View Options

webroot/rsrc/js/core/darkconsole/behavior-dark-console.js

Loading...
Phabricator · Built by Phacility