Page MenuHomePhabricator

Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy
ClosedPublic

Authored by epriestley on Mar 13 2018, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 16 2026, 10:01 PM
Unknown Object (File)
Mar 7 2026, 12:42 AM
Unknown Object (File)
Feb 17 2026, 8:42 PM
Unknown Object (File)
Feb 17 2026, 8:41 PM
Unknown Object (File)
Feb 6 2026, 6:13 PM
Unknown Object (File)
Jan 31 2026, 12:14 PM
Unknown Object (File)
Jan 31 2026, 12:09 PM
Unknown Object (File)
Dec 3 2025, 9:32 AM
Subscribers
None

Details

Summary

See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors.

The new Content-Security-Policy prevents this from functioning.

Replace this with a more modern behavior-driven action instead.

Test Plan
  • Clicked some errors in DarkConsole, saw stack traces appear.
  • Grepped for onclick and jsprintf() to see if I could find any more of these, but came up empty.

Diff Detail

Repository
rP Phabricator
Branch
onclick1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19837
Build 26879: Run Core Tests
Build 26878: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 11:45 PM
This revision was automatically updated to reflect the committed changes.