Page MenuHomePhabricator

Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy
ClosedPublic

Authored by epriestley on Mar 13 2018, 11:39 PM.
Tags
None
Referenced Files
F15460723: D19218.id46021.diff
Tue, Apr 1, 1:31 AM
F15444816: D19218.id.diff
Thu, Mar 27, 11:26 AM
F15438825: D19218.id.diff
Wed, Mar 26, 3:51 AM
F15438792: D19218.diff
Wed, Mar 26, 3:39 AM
F15430250: D19218.id46020.diff
Mon, Mar 24, 6:44 AM
F15425881: D19218.diff
Sun, Mar 23, 6:32 AM
F15414945: D19218.diff
Thu, Mar 20, 3:13 AM
F15375423: D19218.id.diff
Wed, Mar 12, 11:10 PM
Subscribers
None

Details

Summary

See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors.

The new Content-Security-Policy prevents this from functioning.

Replace this with a more modern behavior-driven action instead.

Test Plan
  • Clicked some errors in DarkConsole, saw stack traces appear.
  • Grepped for onclick and jsprintf() to see if I could find any more of these, but came up empty.

Diff Detail

Repository
rP Phabricator
Branch
onclick1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19837
Build 26879: Run Core Tests
Build 26878: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 11:45 PM
This revision was automatically updated to reflect the committed changes.