Page MenuHomePhabricator

Raise a warning when mentioning a user in a comment on a draft revision
ClosedPublic

Authored by epriestley on Mar 12 2018, 11:08 PM.
Tags
None
Referenced Files
F15410793: D19210.id46005.diff
Wed, Mar 19, 8:26 AM
F15397888: D19210.id.diff
Sun, Mar 16, 10:48 PM
Unknown Object (File)
Feb 9 2025, 5:41 AM
Unknown Object (File)
Feb 9 2025, 5:41 AM
Unknown Object (File)
Feb 9 2025, 5:41 AM
Unknown Object (File)
Feb 9 2025, 5:41 AM
Unknown Object (File)
Feb 1 2025, 12:12 AM
Unknown Object (File)
Jan 27 2025, 1:18 AM
Subscribers
None

Details

Summary

See PHI433. Ref T13102. Users in the wild have mixed expecations about exactly what "draft" means. Recent changes have tried to make behavior more clear. As part of clarifying messaging, make it explicit that @mention does not work on drafts by showing users a warning when they try to @mention a user.

Test Plan
  • Mentioned users on drafts, got a warning.
  • Posted normal comments on drafts, no warning.
  • Posted normal/mention comments on non-drafts, no warning.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 12:03 AM
This revision was automatically updated to reflect the committed changes.