See PHI433. Ref T13102. Users in the wild have mixed expecations about exactly what "draft" means. Recent changes have tried to make behavior more clear. As part of clarifying messaging, make it explicit that @mention does not work on drafts by showing users a warning when they try to @mention a user.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13102: Plans: 2018 Week 11 Bonus Content
- Commits
- rPdf8d4dff679b: Raise a warning when mentioning a user in a comment on a draft revision
- Mentioned users on drafts, got a warning.
- Posted normal comments on drafts, no warning.
- Posted normal/mention comments on non-drafts, no warning.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- warnings
- Lint
Lint Passed Severity Location Code Message Advice src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:4304 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 19820 Build 26853: Run Core Tests Build 26852: arc lint + arc unit