Differential D19201

Somewhat improve meme transform code so it is merely very bad
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 6:50 PM.

Details

Reviewers: None
Maniphest Tasks: T5258: Memes use older image transform code without modern error handling
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rPa3d282d33efe: Somewhat improve meme transform code so it is merely very bad

Summary

Depends on D19200. Fixes T5258. Ref T13101. Attempt to simplify and modernize this code and improve error handling.

Test Plan

did real hard dank memes

Diff Detail

Repository

rP Phabricator

Branch

meme4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19798
Build 26823: Run Core Tests
Build 26822: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 6:50 PM

Harbormaster completed remote builds in B19798: Diff 45982.Mar 8 2018, 6:51 PM

epriestley requested review of this revision.Mar 8 2018, 6:51 PM

epriestley added a child revision: D19203: Possibly fix memes in email.Mar 8 2018, 7:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 7:09 PM

Closed by commit rPa3d282d33efe: Somewhat improve meme transform code so it is merely very bad (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

PhabricatorImageTransformer.php

187 lines

macro/

engine/

PhabricatorMemeEngine.php

228 lines

Diff 45982

View Options

src/applications/files/PhabricatorImageTransformer.php