Page MenuHomePhabricator
Differential D19174

Add a "lock log" for debugging where locks are being held
ClosedPublic
Actions

Authored by epriestley on Mar 5 2018, 11:27 PM.
Tags
None
Referenced Files
F14336317: D19174.id45928.diff
Wed, Dec 18, 5:49 PM
F14329445: D19174.diff
Wed, Dec 18, 3:16 PM
Unknown Object (File)
Fri, Dec 13, 5:17 AM
Unknown Object (File)
Tue, Dec 10, 10:58 PM
Unknown Object (File)
Tue, Dec 10, 11:59 AM
Unknown Object (File)
Sat, Nov 30, 8:08 AM
Unknown Object (File)
Thu, Nov 28, 12:28 AM
Unknown Object (File)
Tue, Nov 19, 8:07 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13096: Implement a global lock log to make it easier to debug global locks
Commits
rP44f0664d2c6f: Add a "lock log" for debugging where locks are being held
Summary

Depends on D19173. Ref T13096. Adds an optional, disabled-by-default lock log to make it easier to figure out what is acquiring and holding locks.

Test Plan

Ran bin/lock log --enable, --disable, --name, etc. Saw sensible-looking output with log enabled and daemons restarted. Saw no additional output with log disabled and daemons restarted.

Diff Detail

Repository
rP Phabricator
Branch
lock2
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/infrastructure/util/PhabricatorGlobalLock.php:155XHP79Global Variables
Unit
Tests Passed
Build Status
Buildable 19739
Build 26736: Run Core Tests
Build 26735: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 5 2018, 11:27 PM
Harbormaster failed remote builds in B19739: Diff 45928!Mar 5 2018, 11:27 PM
This revision was not accepted when it landed; it landed in state Draft.Mar 6 2018, 1:55 AM
Closed by commit rP44f0664d2c6f: Add a "lock log" for debugging where locks are being held (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
1 line
resources/
sql/
autopatches/
9 lines
scripts/
setup/
21 lines
src/
8 lines
applications/
daemon/
garbagecollector/
29 lines
management/
222 lines
4 lines
storage/
32 lines
infrastructure/
daemon/
garbagecollector/
6 lines
storage/
management/
workflow/
12 lines
util/
51 lines

Diff 45928

View Options

bin/lock

Loading...
View Options

resources/sql/autopatches/20180305.lock.01.locklog.sql

Loading...
View Options

scripts/setup/manage_lock.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/garbagecollector/PhabricatorDaemonLockLogGarbageCollector.php

Loading...
View Options

src/applications/daemon/management/PhabricatorLockLogManagementWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorLockManagementWorkflow.php

Loading...
View Options

src/applications/daemon/storage/PhabricatorDaemonLockLog.php

Loading...
View Options

src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollector.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
View Options

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...
Phabricator · Built by Phacility