Paths

Table of Contentst

Differential D19155

Remove defunct "download" route in Files pointing to nonexistent controller
ClosedPublic
Actions

Authored by epriestley on Feb 28 2018, 11:21 PM.

Tags

None

Referenced Files

	F15431522: D19155.id45890.diff
	Mon, Mar 24, 12:51 PM

	F15425628: D19155.id45890.diff
	Sun, Mar 23, 5:09 AM

	F15421399: D19155.id45886.diff
	Fri, Mar 21, 11:22 PM

	F15337016: D19155.id45890.diff
	Sun, Mar 9, 3:38 AM

	F15337015: D19155.id45886.diff
	Sun, Mar 9, 3:38 AM

	F15337014: D19155.id.diff
	Sun, Mar 9, 3:38 AM

	F15337011: D19155.diff
	Sun, Mar 9, 3:38 AM

	Unknown Object (File)
	Sun, Mar 2, 5:16 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13094: Improve file behaviors around POST requests and downloads
Commits: rPafc98f5d5d08: Remove defunct "download" route in Files pointing to nonexistent controller

Summary

Depends on D19154. Ref T13094. This controller was removed at some point and this route no longer works.

I plan to add a new download/ route to let us tighten the form-action Content Security Policy.

Test Plan

Grepped for the route and controller, no hits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 28 2018, 11:21 PM

Harbormaster completed remote builds in B19697: Diff 45886.Feb 28 2018, 11:23 PM

epriestley requested review of this revision.Feb 28 2018, 11:23 PM

epriestley added a child revision: D19156: Never generate file download forms which point to the CDN domain, tighten "form-action" CSP.Mar 1 2018, 12:55 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 1:19 AM

Closed by commit rPafc98f5d5d08: Remove defunct "download" route in Files pointing to nonexistent controller (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

application/

PhabricatorFilesApplication.php

1 line

Diff 45890

View Options

src/applications/files/application/PhabricatorFilesApplication.php

Remove defunct "download" route in Files pointing to nonexistent controllerClosedPublicActions