Page MenuHomePhabricator

Stop using forms to download files in file embed and lightbox elements
ClosedPublic

Authored by epriestley on Mar 1 2018, 1:19 AM.
Tags
None
Referenced Files
F15562629: D19157.diff
Wed, Apr 30, 3:31 AM
F15531394: D19157.id45888.diff
Wed, Apr 23, 11:07 AM
F15508095: D19157.id.diff
Wed, Apr 16, 1:30 AM
F15484715: D19157.id45888.diff
Wed, Apr 9, 7:43 PM
F15466083: D19157.id45892.diff
Thu, Apr 3, 1:24 AM
F15461639: D19157.id.diff
Tue, Apr 1, 9:45 AM
F15460150: D19157.diff
Mon, Mar 31, 8:41 PM
F15447670: D19157.id45888.diff
Mar 28 2025, 12:53 AM
Subscribers
None

Details

Summary

Depends on D19156. Ref T13094. This replaces the remaining forms in the file embed view and lightbox with normal download links.

Test Plan

Clicked "Download" and lightbox -> download for embedded files.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 1:21 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.