Page MenuHomePhabricator
Differential D19154

Add "object-src 'none'" to the Content-Security-Policy
ClosedPublic
Actions

Authored by epriestley on Feb 28 2018, 10:17 PM.
Tags
None
Referenced Files
F15458256: D19154.id45885.diff
Sun, Mar 30, 10:15 PM
F15458255: D19154.id45889.diff
Sun, Mar 30, 10:15 PM
F15457897: D19154.diff
Sun, Mar 30, 7:56 PM
F15454318: D19154.id45889.diff
Sat, Mar 29, 5:53 PM
F15454009: D19154.id.diff
Sat, Mar 29, 3:42 PM
F15452965: D19154.id45885.diff
Sat, Mar 29, 8:27 AM
F15444187: D19154.diff
Thu, Mar 27, 8:20 AM
F15432002: D19154.id45889.diff
Mon, Mar 24, 3:45 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T4340: Implement Content-Security-Policy and Strict-Transport-Security headers
Commits
rPa5efd7eedb3c: Add "object-src 'none'" to the Content-Security-Policy
Summary

See PHI399. Ref T4340. We don't require Flash/Java anywhere and can safely block them unconditionally in the Content-Security-Policy header.

Test Plan

Added a <object ... /> tag to a page, saw "Blocked Plug-In" and a CSP warning in the browser console.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 28 2018, 10:17 PM
Harbormaster completed remote builds in B19696: Diff 45885.Feb 28 2018, 10:18 PM
epriestley requested review of this revision.Feb 28 2018, 10:18 PM
epriestley added a child revision: D19155: Remove defunct "download" route in Files pointing to nonexistent controller.Feb 28 2018, 11:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 1:19 AM
Closed by commit rPa5efd7eedb3c: Add "object-src 'none'" to the Content-Security-Policy (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
response/
3 lines

Diff 45889

View Options

src/aphront/response/AphrontResponse.php

Loading...
Phabricator · Built by Phacility