Page MenuHomePhabricator
Differential D19157

Stop using forms to download files in file embed and lightbox elements
ClosedPublic
Actions

Authored by epriestley on Mar 1 2018, 1:19 AM.
Tags
None
Referenced Files
F14474824: D19157.id.diff
Fri, Dec 27, 4:44 PM
Unknown Object (File)
Thu, Dec 26, 11:04 AM
Unknown Object (File)
Fri, Dec 13, 4:23 PM
Unknown Object (File)
Sat, Dec 7, 1:45 PM
Unknown Object (File)
Sat, Nov 30, 3:58 AM
Unknown Object (File)
Nov 25 2024, 10:33 PM
Unknown Object (File)
Nov 25 2024, 7:50 AM
Unknown Object (File)
Nov 24 2024, 11:59 AM
View All 84 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13094: Improve file behaviors around POST requests and downloads
Commits
rPa2fdf14275f9: Stop using forms to download files in file embed and lightbox elements
Summary

Depends on D19156. Ref T13094. This replaces the remaining forms in the file embed view and lightbox with normal download links.

Test Plan

Clicked "Download" and lightbox -> download for embedded files.

Diff Detail

Repository
rP Phabricator
Branch
csp5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19699
Build 26680: Run Core Tests
Build 26679: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 1 2018, 1:19 AM
Harbormaster completed remote builds in B19699: Diff 45888.Mar 1 2018, 1:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2018, 1:21 AM
epriestley requested review of this revision.
Closed by commit rPa2fdf14275f9: Stop using forms to download files in file embed and lightbox elements (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
view/
layout/
20 lines
page/
30 lines
webroot/
rsrc/
js/
core/
59 lines

Diff 45888

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PhabricatorFileLinkView.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...
Phabricator · Built by Phacility