Page MenuHomePhabricator

Add "Committer's projects" and "Author's projects" fields to Herald commit rules
ClosedPublic

Authored by epriestley on Feb 27 2018, 9:59 PM.
Tags
None
Referenced Files
F15420736: D19145.id45867.diff
Fri, Mar 21, 4:24 PM
F15416576: D19145.id.diff
Thu, Mar 20, 12:14 PM
F15413619: D19145.diff
Wed, Mar 19, 8:01 PM
F15405860: D19145.id45867.diff
Tue, Mar 18, 11:57 AM
F15380483: D19145.id45867.diff
Fri, Mar 14, 3:14 AM
F15336988: D19145.id.diff
Sun, Mar 9, 3:38 AM
F15336987: D19145.diff
Sun, Mar 9, 3:38 AM
Unknown Object (File)
Mon, Mar 3, 9:57 PM
Subscribers
None

Details

Summary

Ref T13093. See PHI396. These are possibly somewhat niche, but reasonable to support and consistent with the existing "Pusher's projects".

Also relabel "Pusher's projects" and "Project tags" for consistency and, hopefully, clarity.

Test Plan
  • Created new "commit" and "hook: commit content" Herald rules which run against "Author's projects" and "Committer's projects".
  • Test console'd the "Commit" rules.
  • Pushed through the "Hook" rule.
  • In all cases, saw fields populate appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable