Page MenuHomePhabricator

Add "Committer's projects" and "Author's projects" fields to Herald commit rules
ClosedPublic

Authored by epriestley on Feb 27 2018, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 11:31 PM
Unknown Object (File)
Sat, Nov 23, 4:59 AM
Unknown Object (File)
Tue, Nov 19, 9:20 PM
Unknown Object (File)
Fri, Nov 15, 11:44 PM
Unknown Object (File)
Thu, Nov 14, 4:05 AM
Unknown Object (File)
Mon, Nov 11, 8:09 PM
Unknown Object (File)
Sun, Nov 10, 7:43 AM
Unknown Object (File)
Sun, Nov 10, 6:37 AM
Subscribers
None

Details

Summary

Ref T13093. See PHI396. These are possibly somewhat niche, but reasonable to support and consistent with the existing "Pusher's projects".

Also relabel "Pusher's projects" and "Project tags" for consistency and, hopefully, clarity.

Test Plan
  • Created new "commit" and "hook: commit content" Herald rules which run against "Author's projects" and "Committer's projects".
  • Test console'd the "Commit" rules.
  • Pushed through the "Hook" rule.
  • In all cases, saw fields populate appropriately.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19678
Build 26647: Run Core Tests
Build 26646: arc lint + arc unit