Page MenuHomePhabricator

Add "Committer's projects" and "Author's projects" fields to Herald commit rules
ClosedPublic

Authored by epriestley on Feb 27 2018, 9:59 PM.
Tags
None
Referenced Files
F19913361: D19145.id45869.diff
Fri, Apr 3, 1:40 AM
F19821538: D19145.diff
Mar 6 2026, 10:53 PM
F19815160: D19145.diff
Mar 4 2026, 6:42 PM
F19539424: D19145.diff
Jan 21 2026, 6:58 PM
F19533618: D19145.diff
Jan 20 2026, 7:15 PM
F19040021: D19145.id.diff
Nov 26 2025, 10:36 AM
F19035758: D19145.diff
Nov 25 2025, 6:04 PM
F18904034: D19145.id.diff
Nov 8 2025, 7:26 AM
Subscribers
None

Details

Summary

Ref T13093. See PHI396. These are possibly somewhat niche, but reasonable to support and consistent with the existing "Pusher's projects".

Also relabel "Pusher's projects" and "Project tags" for consistency and, hopefully, clarity.

Test Plan
  • Created new "commit" and "hook: commit content" Herald rules which run against "Author's projects" and "Committer's projects".
  • Test console'd the "Commit" rules.
  • Pushed through the "Hook" rule.
  • In all cases, saw fields populate appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable