Page MenuHomePhabricator

Add "Committer's projects" and "Author's projects" fields to Herald commit rules
ClosedPublic

Authored by epriestley on Feb 27 2018, 9:59 PM.
Tags
None
Referenced Files
F18094919: D19145.diff
Thu, Aug 7, 10:25 PM
F17829775: D19145.id45869.diff
Jul 26 2025, 10:20 AM
F17707586: D19145.id45867.diff
Jul 16 2025, 3:17 PM
F17681229: D19145.diff
Jul 13 2025, 6:11 PM
Unknown Object (File)
Jun 19 2025, 3:50 PM
Unknown Object (File)
May 7 2025, 6:11 PM
Unknown Object (File)
Apr 23 2025, 10:05 AM
Unknown Object (File)
Apr 21 2025, 10:41 AM
Subscribers
None

Details

Summary

Ref T13093. See PHI396. These are possibly somewhat niche, but reasonable to support and consistent with the existing "Pusher's projects".

Also relabel "Pusher's projects" and "Project tags" for consistency and, hopefully, clarity.

Test Plan
  • Created new "commit" and "hook: commit content" Herald rules which run against "Author's projects" and "Committer's projects".
  • Test console'd the "Commit" rules.
  • Pushed through the "Hook" rule.
  • In all cases, saw fields populate appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable