When evaluating the "Branches" Herald field from the test console, use the current viewer
ClosedPublic
Actions

Authored by epriestley on Feb 27 2018, 10:12 PM.

Details

Reviewers: None
Maniphest Tasks: T13093: Plans: 2018 Week 9 Bonus Content
Commits: rP8cbfb386bb87: When evaluating the "Branches" Herald field from the test console, use the…

Summary

Ref T13093. Depends on D19145. See PHI398. Previously, see D18933. This provides the current viewer to ConduitCall so that we don't try to use device credentials from unprivileged web hosts.

Test Plan

Evaluated the "Branches" field locally, saw an appropriate field value.

Diff Detail

Repository

rP Phabricator

Branch

herald2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19679
Build 26649: Run Core Tests
Build 26648: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2018, 10:12 PM

Harbormaster completed remote builds in B19679: Diff 45868.Feb 27 2018, 10:13 PM

epriestley requested review of this revision.Feb 27 2018, 10:13 PM

epriestley edited the summary of this revision. (Show Details)Feb 27 2018, 10:33 PM

epriestley added a task: T13093: Plans: 2018 Week 9 Bonus Content.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 10:37 PM

Closed by commit rP8cbfb386bb87: When evaluating the "Branches" Herald field from the test console, use the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

herald/

DiffusionCommitBranchesHeraldField.php

4 lines

Diff 45868

View Options

src/applications/diffusion/herald/DiffusionCommitBranchesHeraldField.php

When evaluating the "Branches" Herald field from the test console, use the current viewerClosedPublicActions