Page MenuHomePhabricator

Add "Committer's projects" and "Author's projects" fields to Herald commit rules
ClosedPublic

Authored by epriestley on Feb 27 2018, 9:59 PM.
Tags
None
Referenced Files
F13818323: D19145.id45869.diff
Fri, Sep 20, 6:56 AM
Unknown Object (File)
Wed, Sep 11, 6:58 PM
Unknown Object (File)
Mon, Sep 9, 5:15 PM
Unknown Object (File)
Fri, Sep 6, 2:32 AM
Unknown Object (File)
Aug 16 2024, 1:57 AM
Unknown Object (File)
Aug 12 2024, 2:40 AM
Unknown Object (File)
Aug 7 2024, 10:47 AM
Unknown Object (File)
Aug 6 2024, 1:23 PM
Subscribers
None

Details

Summary

Ref T13093. See PHI396. These are possibly somewhat niche, but reasonable to support and consistent with the existing "Pusher's projects".

Also relabel "Pusher's projects" and "Project tags" for consistency and, hopefully, clarity.

Test Plan
  • Created new "commit" and "hook: commit content" Herald rules which run against "Author's projects" and "Committer's projects".
  • Test console'd the "Commit" rules.
  • Pushed through the "Hook" rule.
  • In all cases, saw fields populate appropriately.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19678
Build 26647: Run Core Tests
Build 26646: arc lint + arc unit