Page MenuHomePhabricator
Differential D19122

Fix some of the most obvious bugs in fact generation from Maniphest tasks
ClosedPublic
Actions

Authored by epriestley on Feb 19 2018, 7:38 PM.
Tags
None
Referenced Files
F15408849: D19122.id45817.diff
Wed, Mar 19, 1:53 AM
F15406857: D19122.id45821.diff
Tue, Mar 18, 2:18 PM
F15336964: D19122.id45821.diff
Sun, Mar 9, 3:37 AM
F15336963: D19122.id45817.diff
Sun, Mar 9, 3:37 AM
F15336962: D19122.id.diff
Sun, Mar 9, 3:37 AM
F15336961: D19122.diff
Sun, Mar 9, 3:36 AM
Unknown Object (File)
Sat, Feb 22, 6:59 PM
Unknown Object (File)
Feb 9 2025, 5:30 AM
View All Files
Subscribers
yelirekim

Details

Reviewers
None
Maniphest Tasks
T13083: Plans: Portals and Facts
Commits
rP2fb266de7c1a: Fix some of the most obvious bugs in fact generation from Maniphest tasks
Summary

Depends on D19121. Ref T13083. Group transactions and show groups in the debugging view.

Fix some of the most obvious issues with fact generation:

  • No more 0-point facts.
  • Engine can now generate at least one of every type of fact.
Test Plan

Generated facts, viewed them in the debugging view, fact generation largely appeared to align with reality. No more "no facts in storage" facts.

Diff Detail

Repository
rP Phabricator
Branch
facts4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php:108XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19625
Build 26570: Run Core Tests
Build 26569: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 19 2018, 7:38 PM
Herald added a subscriber: yelirekim. · View Herald TranscriptFeb 19 2018, 7:38 PM
Harbormaster completed remote builds in B19625: Diff 45817.Feb 19 2018, 7:39 PM
epriestley requested review of this revision.Feb 19 2018, 7:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2018, 8:07 PM
Closed by commit rP2fb266de7c1a: Fix some of the most obvious bugs in fact generation from Maniphest tasks (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45817

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactObjectController.php

Loading...
View Options

src/applications/fact/daemon/PhabricatorFactDaemon.php

Loading...
View Options

src/applications/fact/engine/PhabricatorFactEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorFactManiphestTaskEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php

Loading...
View Options

src/applications/fact/engine/PhabricatorTransactionFactEngine.php

Loading...
Phabricator · Built by Phacility