Differential D19122

Fix some of the most obvious bugs in fact generation from Maniphest tasks
ClosedPublic
Actions

Authored by epriestley on Feb 19 2018, 7:38 PM.

Details

Reviewers: None
Maniphest Tasks: T13083: Plans: Portals and Facts
Commits: rP2fb266de7c1a: Fix some of the most obvious bugs in fact generation from Maniphest tasks

Summary

Depends on D19121. Ref T13083. Group transactions and show groups in the debugging view.

Fix some of the most obvious issues with fact generation:

No more 0-point facts.
Engine can now generate at least one of every type of fact.

Test Plan

Generated facts, viewed them in the debugging view, fact generation largely appeared to align with reality. No more "no facts in storage" facts.

Diff Detail

Repository

rP Phabricator

Branch

facts4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php:108	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19625
Build 26570: Run Core Tests
Build 26569: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 19 2018, 7:38 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptFeb 19 2018, 7:38 PM

Harbormaster completed remote builds in B19625: Diff 45817.Feb 19 2018, 7:39 PM

epriestley requested review of this revision.Feb 19 2018, 7:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2018, 8:07 PM

Closed by commit rP2fb266de7c1a: Fix some of the most obvious bugs in fact generation from Maniphest tasks (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

fact/

controller/

PhabricatorFactObjectController.php

56 lines

daemon/

PhabricatorFactDaemon.php

5 lines

engine/

PhabricatorFactEngine.php

14 lines

PhabricatorFactManiphestTaskEngine.php

	PhabricatorManiphestTaskFactEngine.php
	PhabricatorFactManiphestTaskEngine.php

67 lines

PhabricatorTransactionFactEngine.php

84 lines

Diff 45817

View Options

src/__phutil_library_map__.php

View Options

src/applications/fact/controller/PhabricatorFactObjectController.php

View Options

src/applications/fact/daemon/PhabricatorFactDaemon.php

View Options

src/applications/fact/engine/PhabricatorFactEngine.php

View Options

src/applications/fact/engine/PhabricatorFactManiphestTaskEngine.php

View Options

src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php

View Options

src/applications/fact/engine/PhabricatorTransactionFactEngine.php

Fix some of the most obvious bugs in fact generation from Maniphest tasksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45817

src/__phutil_library_map__.php

src/applications/fact/controller/PhabricatorFactObjectController.php

src/applications/fact/daemon/PhabricatorFactDaemon.php

src/applications/fact/engine/PhabricatorFactEngine.php

src/applications/fact/engine/PhabricatorFactManiphestTaskEngine.php

src/applications/fact/engine/PhabricatorManiphestTaskFactEngine.php

src/applications/fact/engine/PhabricatorTransactionFactEngine.php

Fix some of the most obvious bugs in fact generation from Maniphest tasks
ClosedPublic
Actions

Revision Contents
Changeset List