Page MenuHomePhabricator

Provide a page for examining the facts an object generates
ClosedPublic

Authored by epriestley on Feb 19 2018, 5:43 PM.
Tags
None
Referenced Files
F15470386: D19121.id45820.diff
Fri, Apr 4, 9:44 PM
F15460600: D19121.id45820.diff
Tue, Apr 1, 12:21 AM
F15445058: D19121.id45820.diff
Thu, Mar 27, 12:22 PM
F15436824: D19121.id45816.diff
Tue, Mar 25, 4:37 PM
F15432300: D19121.id.diff
Mon, Mar 24, 5:22 PM
F15427910: D19121.id45820.diff
Sun, Mar 23, 5:11 PM
F15416095: D19121.id45820.diff
Thu, Mar 20, 9:17 AM
F15409289: D19121.id45820.diff
Wed, Mar 19, 4:00 AM
Subscribers

Details

Summary

Depends on D19120. Ref T13083. When you write a fact engine, it's currently somewhat difficult to figure out exactly what it's doing. It would also be difficult to diagnose bugs or report them to the upstream.

To ease this, add a page which shows all the facts an object generates. This allows you to iterate on an engine quickly without needing to reanalyze facts, take a screenshot, easily compare the timeline to the fact view, etc.

Test Plan

Viewed the object fact page for several objects.

Diff Detail

Repository
rP Phabricator
Branch
facts3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19624
Build 26568: Run Core Tests
Build 26567: arc lint + arc unit