Page MenuHomePhabricator

Provide a page for examining the facts an object generates
ClosedPublic

Authored by epriestley on Feb 19 2018, 5:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:01 AM
Unknown Object (File)
Fri, Apr 19, 7:25 PM
Unknown Object (File)
Thu, Apr 11, 10:33 AM
Unknown Object (File)
Sat, Mar 30, 6:56 PM
Unknown Object (File)
Thu, Mar 28, 4:03 PM
Unknown Object (File)
Thu, Mar 28, 12:05 PM
Unknown Object (File)
Mar 27 2024, 6:14 PM
Unknown Object (File)
Mar 23 2024, 5:44 PM
Subscribers

Details

Summary

Depends on D19120. Ref T13083. When you write a fact engine, it's currently somewhat difficult to figure out exactly what it's doing. It would also be difficult to diagnose bugs or report them to the upstream.

To ease this, add a page which shows all the facts an object generates. This allows you to iterate on an engine quickly without needing to reanalyze facts, take a screenshot, easily compare the timeline to the fact view, etc.

Test Plan

Viewed the object fact page for several objects.

Diff Detail

Repository
rP Phabricator
Branch
facts3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19624
Build 26568: Run Core Tests
Build 26567: arc lint + arc unit