Page MenuHomePhabricator

Add Owners Package support for "Commit Hook: Content" Herald rules
ClosedPublic

Authored by epriestley on Feb 16 2018, 12:44 PM.
Tags
None
Referenced Files
F15367570: D19104.id45788.diff
Tue, Mar 11, 7:40 PM
F15343496: D19104.diff
Sun, Mar 9, 11:12 PM
Unknown Object (File)
Mon, Mar 3, 7:32 PM
Unknown Object (File)
Sat, Mar 1, 4:43 PM
Unknown Object (File)
Jan 31 2025, 10:01 AM
Unknown Object (File)
Jan 28 2025, 3:23 AM
Unknown Object (File)
Jan 20 2025, 10:35 AM
Unknown Object (File)
Jan 2 2025, 4:52 PM
Subscribers
None

Details

Summary

See PHI370. Support the "Affected packages" and "Affected package owners" Herald fields in pre-commit hooks.

I believe there's no technical reason these fields aren't supported and this was just overlooked.

Test Plan

Wrote a rule which makes use of the new fields, pushed commits through it. Checked transcripts and saw sensible-looking values.

Diff Detail

Repository
rP Phabricator
Branch
precommit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19586
Build 26512: Run Core Tests
Build 26511: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.