Page MenuHomePhabricator

Add Owners Package support for "Commit Hook: Content" Herald rules
ClosedPublic

Authored by epriestley on Feb 16 2018, 12:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 4:50 AM
Unknown Object (File)
Wed, Oct 30, 8:36 PM
Unknown Object (File)
Oct 23 2024, 7:04 PM
Unknown Object (File)
Oct 23 2024, 2:22 AM
Unknown Object (File)
Oct 22 2024, 1:51 AM
Unknown Object (File)
Oct 20 2024, 11:24 PM
Unknown Object (File)
Oct 19 2024, 12:39 AM
Unknown Object (File)
Oct 19 2024, 12:37 AM
Subscribers
None

Details

Summary

See PHI370. Support the "Affected packages" and "Affected package owners" Herald fields in pre-commit hooks.

I believe there's no technical reason these fields aren't supported and this was just overlooked.

Test Plan

Wrote a rule which makes use of the new fields, pushed commits through it. Checked transcripts and saw sensible-looking values.

Diff Detail

Repository
rP Phabricator
Branch
precommit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19586
Build 26512: Run Core Tests
Build 26511: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.