Page MenuHomePhabricator

Add Owners Package support for "Commit Hook: Content" Herald rules
ClosedPublic

Authored by epriestley on Feb 16 2018, 12:44 PM.
Tags
None
Referenced Files
F15528377: D19104.diff
Tue, Apr 22, 10:47 AM
F15498429: D19104.id.diff
Sun, Apr 13, 12:56 PM
F15491043: D19104.id45788.diff
Fri, Apr 11, 10:49 PM
F15487677: D19104.id.diff
Thu, Apr 10, 4:09 PM
F15486003: D19104.id.diff
Thu, Apr 10, 4:18 AM
F15483532: D19104.diff
Wed, Apr 9, 12:55 PM
F15474447: D19104.diff
Sun, Apr 6, 8:45 AM
F15367570: D19104.id45788.diff
Mar 11 2025, 7:40 PM
Subscribers
None

Details

Summary

See PHI370. Support the "Affected packages" and "Affected package owners" Herald fields in pre-commit hooks.

I believe there's no technical reason these fields aren't supported and this was just overlooked.

Test Plan

Wrote a rule which makes use of the new fields, pushed commits through it. Checked transcripts and saw sensible-looking values.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.