Page MenuHomePhabricator

Modularize the "jump nav" behaviors in global search
ClosedPublic

Authored by epriestley on Feb 15 2018, 12:31 AM.
Tags
None
Referenced Files
F14416013: D19088.id45753.diff
Tue, Dec 24, 8:06 PM
F14415958: D19088.id45749.diff
Tue, Dec 24, 7:50 PM
F14408959: D19088.diff
Tue, Dec 24, 5:49 AM
Unknown Object (File)
Sun, Dec 22, 9:16 PM
Unknown Object (File)
Sat, Dec 21, 5:31 PM
Unknown Object (File)
Sat, Dec 21, 5:31 PM
Unknown Object (File)
Sat, Dec 21, 5:31 PM
Unknown Object (File)
Sat, Dec 21, 5:31 PM
Subscribers
None

Details

Summary

Depends on D19087. Ref T13079. This still doesn't feel like the most clean, general system in the world, but is a step forward from hard-coded switch() stuff.

Test Plan
  • Jumped to r.
  • Jumped to a.
  • Jumped to r poe (multiple results).
  • Jumped to r poetry (one result).
  • Jumped to r syzygy (no results).
  • Jumped to p.
  • Jumped to p robot (multiple results); p assessment (one result).
    • The behavior for p <string> has changed slightly but should be more powerful now (it's consistent with r <string>).
  • Jumped to s <symbol> and s <context>-><symbol>.
  • Jumped to d.
  • Jumped to f.
  • Jumped to t.
  • Jumped to T123, D123, @dog, PHID-DREV-abcd, etc.

Diff Detail

Repository
rP Phabricator
Branch
datasource2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19553
Build 26462: Run Core Tests
Build 26461: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 2:08 AM
This revision was automatically updated to reflect the committed changes.