Page MenuHomePhabricator
Differential D19077

Don't let `bin/drydock lease --attributes` overwrite blueprints
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 5:35 PM.
Tags
None
Referenced Files
F15432103: D19077.id45721.diff
Mon, Mar 24, 4:06 PM
F15430480: D19077.id45733.diff
Mon, Mar 24, 7:52 AM
F15427703: D19077.id45721.diff
Sun, Mar 23, 3:41 PM
F15427580: D19077.id.diff
Sun, Mar 23, 3:01 PM
F15423080: D19077.diff
Sat, Mar 22, 12:43 PM
F15396743: D19077.id.diff
Sun, Mar 16, 4:04 PM
F15334733: D19077.id45721.diff
Sat, Mar 8, 11:45 AM
F15331615: D19077.id45733.diff
Fri, Mar 7, 11:54 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits
rP2994753d2333: Don't let `bin/drydock lease --attributes` overwrite blueprints
Summary

Depends on D19076. Ref T13073. Blueprints are stored as an attribute and setAttributes() overwrites all attributes.

This is sorta junk but make it less obviously broken, at least.

Test Plan

Ran bin/drydock lease --type working-copy --attributes x=y without instantly getting a fatal about "no blueprint PHIDs".

Diff Detail

Repository
rP Phabricator
Branch
dry9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19524
Build 26422: Run Core Tests
Build 26421: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2018, 5:35 PM
Owners added a subscriber: Restricted Owners Package.Feb 13 2018, 5:35 PM
Harbormaster completed remote builds in B19524: Diff 45721.Feb 13 2018, 5:36 PM
epriestley requested review of this revision.Feb 13 2018, 5:36 PM
epriestley added a child revision: D19078: Reduce collision rate for concurrency-limiting slot locks.Feb 13 2018, 5:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 9:20 PM
Closed by commit rP2994753d2333: Don't let `bin/drydock lease --attributes` overwrite blueprints (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
management/
8 lines

Diff 45721

View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php

Loading...
Phabricator · Built by Phacility