Differential D19072

While waiting for a "bin/drydock" lease to activate, entertain the user with log output
ClosedPublic
Actions

Authored by epriestley on Feb 13 2018, 11:50 AM.

Details

Reviewers: None
Maniphest Tasks: T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits: rPb833e324bd4a: While waiting for a "bin/drydock" lease to activate, entertain the user with…

Summary

Depends on D19071. Ref T13073. While the daemons are supposedly doing things, show the user any logs they generate. There's often something relevant but unearthing it can be involved.

Test Plan

Screen Shot 2018-02-13 at 3.46.37 AM.png (222×730 px, 42 KB)

Diff Detail

Repository

rP Phabricator

Branch

dry3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19519
Build 26412: Run Core Tests
Build 26411: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2018, 11:50 AM

Owners added a subscriber: Restricted Owners Package.Feb 13 2018, 11:50 AM

Harbormaster completed remote builds in B19519: Diff 45716.Feb 13 2018, 11:51 AM

epriestley requested review of this revision.Feb 13 2018, 11:51 AM

epriestley added a child revision: D19073: When `bin/drydock lease` is interrupted, release leases.Feb 13 2018, 12:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 9:13 PM

Closed by commit rPb833e324bd4a: While waiting for a "bin/drydock" lease to activate, entertain the user with… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

management/

DrydockManagementLeaseWorkflow.php

78 lines

storage/

DrydockLease.php

32 lines

Diff 45716

View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php