Differential D19010

Fix another Git 2.16.0 CLI compatibility issue
ClosedPublic
Actions

Authored by epriestley on Feb 7 2018, 12:02 AM.

Tags

None

Referenced Files

	F19520222: D19010.id45594.diff
	Fri, Jan 16, 12:05 PM

	F18993745: D19010.id45594.diff
	Nov 19 2025, 8:24 AM

	F18905575: D19010.id.diff
	Nov 8 2025, 2:40 PM

	F18773118: D19010.diff
	Oct 9 2025, 7:18 AM

	F18770821: D19010.id45579.diff
	Oct 8 2025, 3:14 PM

	F18752129: D19010.id.diff
	Oct 4 2025, 2:13 PM

	F18748593: D19010.diff
	Oct 3 2025, 11:36 PM

	F18524535: D19010.diff
	Sep 6 2025, 12:58 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa5bbadbaba02: Fix another Git 2.16.0 CLI compatibility issue

Summary

This command also needs a "." instead of an empty string now.

(This powers the file browser typeahead in Diffusion.)

Test Plan

Will test in production since there's still no easy 2.16 installer for macOS.

Diff Detail

Repository

rP Phabricator

Branch

pathspec1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19373
Build 26196: Run Core Tests
Build 26195: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 7 2018, 12:02 AM

Harbormaster completed remote builds in B19373: Diff 45579.Feb 7 2018, 12:03 AM

epriestley requested review of this revision.Feb 7 2018, 12:03 AM

amckinley accepted this revision.Feb 7 2018, 10:44 PM

This revision is now accepted and ready to land.Feb 7 2018, 10:44 PM

epriestley added inline comments.Feb 7 2018, 10:44 PM

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php
40	(This link is dead and I don't know what was there.)

Closed by commit rPa5bbadbaba02: Fix another Git 2.16.0 CLI compatibility issue (authored by epriestley). · Explain WhyFeb 8 2018, 1:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryPathsConduitAPIMethod.php

6 lines

Diff 45579

View Options

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

Fix another Git 2.16.0 CLI compatibility issueClosedPublicActions