Page MenuHomePhabricator
Differential D19010

Fix another Git 2.16.0 CLI compatibility issue
ClosedPublic
Actions

Authored by epriestley on Feb 7 2018, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 20 2025, 1:31 PM
Unknown Object (File)
Jan 16 2025, 11:12 AM
Unknown Object (File)
Dec 29 2024, 3:08 AM
Unknown Object (File)
Dec 25 2024, 1:02 PM
Unknown Object (File)
Dec 21 2024, 11:12 PM
Unknown Object (File)
Dec 7 2024, 3:15 PM
Unknown Object (File)
Dec 7 2024, 10:53 AM
Unknown Object (File)
Nov 28 2024, 12:35 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPa5bbadbaba02: Fix another Git 2.16.0 CLI compatibility issue
Summary

This command also needs a "." instead of an empty string now.

(This powers the file browser typeahead in Diffusion.)

Test Plan

Will test in production since there's still no easy 2.16 installer for macOS.

Diff Detail

Repository
rP Phabricator
Branch
pathspec1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19373
Build 26196: Run Core Tests
Build 26195: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 7 2018, 12:02 AM
Harbormaster completed remote builds in B19373: Diff 45579.Feb 7 2018, 12:03 AM
epriestley requested review of this revision.Feb 7 2018, 12:03 AM
amckinley accepted this revision.Feb 7 2018, 10:44 PM
This revision is now accepted and ready to land.Feb 7 2018, 10:44 PM
epriestley added inline comments.Feb 7 2018, 10:44 PM
src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php
40

(This link is dead and I don't know what was there.)

Closed by commit rPa5bbadbaba02: Fix another Git 2.16.0 CLI compatibility issue (authored by epriestley). · Explain WhyFeb 8 2018, 1:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
6 lines

Diff 45579

View Options

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility