Page MenuHomePhabricator

Allow revisions to revert commits and one another, and commits to revert revisions
ClosedPublic

Authored by epriestley on Jan 31 2018, 8:27 PM.
Tags
None
Referenced Files
F14792598: D18978.id45532.diff
Fri, Jan 24, 11:32 PM
F14792597: D18978.id45512.diff
Fri, Jan 24, 11:32 PM
F14792596: D18978.id.diff
Fri, Jan 24, 11:32 PM
Unknown Object (File)
Tue, Jan 21, 3:42 PM
Unknown Object (File)
Sat, Jan 18, 6:48 PM
Unknown Object (File)
Thu, Jan 16, 5:05 AM
Unknown Object (File)
Tue, Jan 7, 7:16 PM
Unknown Object (File)
Dec 24 2024, 5:41 PM
Subscribers
None

Details

Summary

Ref T13057. This makes "reverts" syntax more visible and useful. In particular, you can now Reverts Dxx in a revision or commit, and Reverts <hash> from a revision.

When you do, the corresponding object will get a more-visible cross-reference marker in its timeline:

Screen Shot 2018-01-31 at 12.25.33 PM.png (46×360 px, 9 KB)

From here, we can look at surfacing revert information more heavily, since we can now query it on revision/commit pages via edges.

Test Plan

Used "reverts <hash>" and "reverts <revision>" in Differential and Diffusion, got sensible results in the timeline.

Diff Detail

Repository
rP Phabricator
Branch
revert1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19301
Build 26084: Run Core Tests
Build 26083: arc lint + arc unit