Page MenuHomePhabricator

Allow revisions to revert commits and one another, and commits to revert revisions
ClosedPublic

Authored by epriestley on Jan 31 2018, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 9:47 PM
Unknown Object (File)
Thu, Nov 21, 10:54 AM
Unknown Object (File)
Sun, Nov 17, 12:05 PM
Unknown Object (File)
Thu, Nov 14, 7:05 AM
Unknown Object (File)
Thu, Nov 14, 4:07 AM
Unknown Object (File)
Thu, Nov 14, 2:32 AM
Unknown Object (File)
Wed, Nov 13, 10:27 PM
Unknown Object (File)
Fri, Nov 8, 6:33 PM
Subscribers
None

Details

Summary

Ref T13057. This makes "reverts" syntax more visible and useful. In particular, you can now Reverts Dxx in a revision or commit, and Reverts <hash> from a revision.

When you do, the corresponding object will get a more-visible cross-reference marker in its timeline:

Screen Shot 2018-01-31 at 12.25.33 PM.png (46×360 px, 9 KB)

From here, we can look at surfacing revert information more heavily, since we can now query it on revision/commit pages via edges.

Test Plan

Used "reverts <hash>" and "reverts <revision>" in Differential and Diffusion, got sensible results in the timeline.

Diff Detail

Repository
rP Phabricator
Branch
revert1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19301
Build 26084: Run Core Tests
Build 26083: arc lint + arc unit