Write edge transactions in a more compact way
ClosedPublic
Actions

Authored by epriestley on Jan 27 2018, 1:56 PM.

Details

Reviewers

Maniphest Tasks

T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs

Commits

rPdb8ba29925be: (stable) Write edge transactions in a more compact way
rPe5639a8ed90f: Write edge transactions in a more compact way

Summary

Depends on D18946. Ref T13051. Begins writing edge transactions as just a list of changed PHIDs.

Test Plan

Added, edited, and removed projects. Reviewed transaction record and database. Saw no user-facing changes but a far more compact database representation.

Diff Detail

Repository

rP Phabricator

Branch

edge2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1003	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19247
Build 26010: Run Core Tests
Build 26009: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 27 2018, 1:56 PM

Harbormaster failed remote builds in B19228: Diff 45444!Jan 27 2018, 1:57 PM

epriestley added a child revision: D18948: Add `bin/garbage compact-edges` to compact edges into the new format.Jan 27 2018, 2:19 PM

Remove literal debugging code.

Harbormaster completed remote builds in B19230: Diff 45446.Jan 27 2018, 2:46 PM

epriestley requested review of this revision.Jan 27 2018, 2:46 PM

amckinley accepted this revision.Jan 29 2018, 7:24 PM

amckinley added inline comments.

src/infrastructure/edges/util/PhabricatorEdgeChangeRecord.php
80	"this is"
86	Oh, I thought we still needed to keep this as a list inside of a map?

This revision is now accepted and ready to land.Jan 29 2018, 7:24 PM

Oh, I thought we still needed to keep this as a list inside of a map?

The change ended up a lot simpler than I thought at first, so I just went with a plain list.

Fix missing word in comment.

Harbormaster completed remote builds in B19247: Diff 45463.Jan 29 2018, 7:33 PM

Closed by commit rPe5639a8ed90f: Write edge transactions in a more compact way (authored by epriestley). · Explain WhyJan 29 2018, 7:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

26 lines

infrastructure/

edges/

util/

PhabricatorEdgeChangeRecord.php

27 lines

Diff 45463

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php