Write edge transactions in a more compact way
ClosedPublic
Actions

Authored by epriestley on Jan 27 2018, 1:56 PM.

Details

Reviewers

Maniphest Tasks

T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs

Commits

rPdb8ba29925be: (stable) Write edge transactions in a more compact way
rPe5639a8ed90f: Write edge transactions in a more compact way

Summary

Depends on D18946. Ref T13051. Begins writing edge transactions as just a list of changed PHIDs.

Test Plan

Added, edited, and removed projects. Reviewed transaction record and database. Saw no user-facing changes but a far more compact database representation.

Diff Detail

Repository

rP Phabricator

Branch

edge2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1003	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19228
Build 25972: Run Core Tests
Build 25971: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	21 ms	PhabricatorPhortuneTestCase::Unknown Unit Message ("") EXCEPTION (DomainException): Attempt to write to undeclared property PhabricatorEdgeChangeRecord::debug. #0 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1015): Phobject->__set('debug', true) #1 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/phortune/storage/PhortuneAccount.php(51): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhortuneAccount), Array)
	87 ms	PhabricatorProjectCoreTestCase::Unknown Unit Message ("") EXCEPTION (DomainException): Attempt to write to undeclared property PhabricatorEdgeChangeRecord::debug. #0 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1015): Phobject->__set('debug', true) #1 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php(1593): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhabricatorProject), Array)
	48 ms	PhabricatorProjectCoreTestCase::Unknown Unit Message ("") EXCEPTION (DomainException): Attempt to write to undeclared property PhabricatorEdgeChangeRecord::debug. #0 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1015): Phobject->__set('debug', true) #1 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php(1593): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhabricatorProject), Array)
	53 ms	PhabricatorProjectCoreTestCase::Unknown Unit Message ("") EXCEPTION (DomainException): Attempt to write to undeclared property PhabricatorEdgeChangeRecord::debug. #0 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1015): Phobject->__set('debug', true) #1 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php(1366): PhabricatorApplicationTransactionEditor->applyTransactions(Object(ManiphestTask), Array)
	79 ms	PhabricatorProjectCoreTestCase::Unknown Unit Message ("") EXCEPTION (DomainException): Attempt to write to undeclared property PhabricatorEdgeChangeRecord::debug. #0 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(1015): Phobject->__set('debug', true) #1 /core/data/drydock/workingcopy-85/repo/phabricator/src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php(1593): PhabricatorApplicationTransactionEditor->applyTransactions(Object(PhabricatorProject), Array)
		View Full Test Results (15 Failed · 337 Passed)