Page MenuHomePhabricator

Bring new password validation into AuthPasswordEngine
ClosedPublic

Authored by epriestley on Jan 22 2018, 12:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 9:27 PM
Unknown Object (File)
Wed, Nov 27, 5:41 AM
Unknown Object (File)
Wed, Nov 27, 3:07 AM
Unknown Object (File)
Mon, Nov 25, 12:24 PM
Unknown Object (File)
Sat, Nov 23, 7:39 AM
Unknown Object (File)
Mon, Nov 18, 4:38 PM
Unknown Object (File)
Fri, Nov 15, 8:55 AM
Unknown Object (File)
Wed, Nov 13, 3:06 AM
Subscribers
None

Details

Summary

Ref T13043. We have ~4 copies of this logic (registration, lost password recovery, set password, set VCS password).

Currently it varies a bit from case to case, but since it's all going to be basically identical once account passwords swap to the new infrastructure, bring it into the Engine so it can live in one place.

This also fixes VCS passwords not being affected by account.minimum-password-length.

Test Plan

Hit all errors in "VCS Password" panel. Successfully changed password.

Diff Detail

Repository
rP Phabricator
Branch
revoke12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19138
Build 25845: Run Core Tests
Build 25844: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
91

strlen($raw_confirm)?

This revision now requires changes to proceed.Jan 23 2018, 6:39 PM
  • Fix strlen().
  • Tested to actually hit this error.
  • Changed password.
This revision is now accepted and ready to land.Jan 23 2018, 6:43 PM
This revision was automatically updated to reflect the committed changes.