Page MenuHomePhabricator

Bring new password validation into AuthPasswordEngine
ClosedPublic

Authored by epriestley on Jan 22 2018, 12:35 AM.
Tags
None
Referenced Files
F15539908: D18902.id.diff
Fri, Apr 25, 5:56 AM
F15537490: D18902.id.diff
Thu, Apr 24, 2:06 PM
F15536501: D18902.id45351.diff
Thu, Apr 24, 10:13 AM
F15530169: D18902.diff
Wed, Apr 23, 2:27 AM
F15519882: D18902.id45318.diff
Sun, Apr 20, 12:32 AM
F15437335: D18902.id45318.diff
Mar 25 2025, 6:54 PM
F15432120: D18902.id.diff
Mar 24 2025, 4:14 PM
F15427969: D18902.id45358.diff
Mar 23 2025, 5:28 PM
Subscribers
None

Details

Summary

Ref T13043. We have ~4 copies of this logic (registration, lost password recovery, set password, set VCS password).

Currently it varies a bit from case to case, but since it's all going to be basically identical once account passwords swap to the new infrastructure, bring it into the Engine so it can live in one place.

This also fixes VCS passwords not being affected by account.minimum-password-length.

Test Plan

Hit all errors in "VCS Password" panel. Successfully changed password.

Diff Detail

Repository
rP Phabricator
Branch
revoke12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19105
Build 25791: Run Core Tests
Build 25790: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/auth/engine/PhabricatorAuthPasswordEngine.php
91

strlen($raw_confirm)?

This revision now requires changes to proceed.Jan 23 2018, 6:39 PM
  • Fix strlen().
  • Tested to actually hit this error.
  • Changed password.
This revision is now accepted and ready to land.Jan 23 2018, 6:43 PM
This revision was automatically updated to reflect the committed changes.