Fix an issue where certain configurations could fail to publish revision feed stories
ClosedPublic
Actions

Authored by epriestley on Jan 19 2018, 10:27 PM.

Tags

None

Referenced Files

	F14027527: D18886.diff
	Fri, Nov 8, 7:48 AM

	F13974054: D18886.diff
	Fri, Oct 18, 3:51 AM

	Unknown Object (File)
	Sep 20 2024, 2:57 PM

	Unknown Object (File)
	Sep 20 2024, 11:59 AM

	Unknown Object (File)
	Sep 18 2024, 3:23 PM

	Unknown Object (File)
	Sep 4 2024, 6:26 AM

	Unknown Object (File)
	Sep 2 2024, 8:08 AM

	Unknown Object (File)
	Sep 2 2024, 6:32 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP3b7547e726ed: Fix an issue where certain configurations could fail to publish revision feed…

Summary

See PHI292. This is just a generalization of D18851: feed stories have the same issue as mail. Don't hide "requested a review" in either mail or feed.

Test Plan

Enable prototypes.
No harbormaster builds.
Create a revision.
- Pre-patch: no feed story.
- Post-patch: feed story.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 19 2018, 10:27 PM

Harbormaster completed remote builds in B19085: Diff 45298.Jan 19 2018, 10:28 PM

epriestley requested review of this revision.Jan 19 2018, 10:28 PM

amckinley accepted this revision.Jan 19 2018, 10:29 PM

This revision is now accepted and ready to land.Jan 19 2018, 10:29 PM

Closed by commit rP3b7547e726ed: Fix an issue where certain configurations could fail to publish revision feed… (authored by epriestley). · Explain WhyJan 19 2018, 11:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialTransaction.php

13 lines

Diff 45302

View Options

src/applications/differential/storage/DifferentialTransaction.php

Fix an issue where certain configurations could fail to publish revision feed storiesClosedPublicActions