Page MenuHomePhabricator

Remove legacy transaction editor "getDisableEmail()" method
ClosedPublic

Authored by epriestley on Jan 19 2018, 3:48 PM.
Tags
None
Referenced Files
F19153157: D18881.diff
Thu, Dec 11, 7:49 AM
F19031437: D18881.id45273.diff
Nov 25 2025, 1:07 AM
F18924481: D18881.id.diff
Nov 9 2025, 5:45 PM
F18904111: D18881.diff
Nov 8 2025, 7:47 AM
F18783786: D18881.id45273.diff
Oct 13 2025, 9:31 AM
F18755125: D18881.id45292.diff
Oct 5 2025, 3:56 AM
F18755063: D18881.id45273.diff
Oct 5 2025, 3:25 AM
F18689409: D18881.id.diff
Sep 26 2025, 6:03 PM
Subscribers
None

Details

Summary

Ref T13042. This is a very, very old policy-violating option from yesteryear which supported build systems publishing updates by adding comments to revisions, without sending email about it.

Harbormaster has served this role for a long time and this is policy-violating in the general case (it allows attackers to act in secret).

Test Plan

Grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
bulk16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19057
Build 25719: Run Core Tests
Build 25718: arc lint + arc unit