HomePhabricator

Remove legacy transaction editor "getDisableEmail()" method

Description

Remove legacy transaction editor "getDisableEmail()" method

Summary:
Ref T13042. This is a very, very old policy-violating option from yesteryear which supported build systems publishing updates by adding comments to revisions, without sending email about it.

Harbormaster has served this role for a long time and this is policy-violating in the general case (it allows attackers to act in secret).

Test Plan: Grepped for affected symbols.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13042

Differential Revision: https://secure.phabricator.com/D18881

Details

Provenance
epriestleyAuthored on Jan 19 2018, 3:44 PM
epriestleyPushed on Jan 19 2018, 9:23 PM
Reviewer
amckinley
Differential Revision
D18881: Remove legacy transaction editor "getDisableEmail()" method
Parents
rP7a431813373a: Organize bulk edit actions into nice groups
Branches
Unknown
Tags
Unknown
Tasks
T13042: Add a "silent" mode to bulk edits
Build Status
Buildable 19079
Build 25744: Run Core Tests