Page MenuHomePhabricator
Differential D18859

Add a couple of clarifying comments to the Mercurial protocol parser
ClosedPublic
Actions

Authored by epriestley on Jan 4 2018, 10:13 PM.
Tags
None
Referenced Files
F18945648: D18859.id.diff
Nov 11 2025, 6:41 PM
F18936917: D18859.diff
Nov 10 2025, 9:34 PM
F18906810: D18859.id45240.diff
Nov 8 2025, 8:33 PM
F18887289: D18859.diff
Nov 7 2025, 5:52 AM
F18873929: D18859.id.diff
Nov 5 2025, 12:13 PM
F18865135: D18859.id45240.diff
Nov 3 2025, 10:45 AM
F18766917: D18859.id45240.diff
Oct 7 2025, 7:22 PM
F18740788: D18859.diff
Oct 2 2025, 5:52 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13036: Fix issues with recent Mercurial wire protocol versions
Commits
rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser
Summary

See D18857. Ref T13036. See PHI275. Explain what's going on here a little better since it isn't entirely obvious and debugging these stream parsers is a gigantic pain.

Test Plan

Read text.

Diff Detail

Repository
rP Phabricator
Branch
hg4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19021
Build 25659: Run Core Tests
Build 25658: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
ssh/
19 lines

Diff 45239

View Options

src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php

Loading...
Phabricator · Built by Phacility