Differential D18859

Add a couple of clarifying comments to the Mercurial protocol parser
ClosedPublic
Actions

Authored by epriestley on Jan 4 2018, 10:13 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13036: Fix issues with recent Mercurial wire protocol versions

Commits

rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser

Summary

See D18857. Ref T13036. See PHI275. Explain what's going on here a little better since it isn't entirely obvious and debugging these stream parsers is a gigantic pain.

Test Plan

Read text.

Diff Detail

Repository

rP Phabricator

Branch

hg4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19021
Build 25659: Run Core Tests
Build 25658: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 4 2018, 10:13 PM

Harbormaster completed remote builds in B19021: Diff 45239.Jan 4 2018, 10:14 PM

epriestley requested review of this revision.Jan 4 2018, 10:14 PM

👍

This revision is now accepted and ready to land.Jan 4 2018, 10:15 PM

Closed by commit rP554359203467: Add a couple of clarifying comments to the Mercurial protocol parser (authored by epriestley). · Explain WhyJan 4 2018, 10:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

ssh/

DiffusionMercurialWireClientSSHProtocolChannel.php

19 lines

Diff 45239

View Options

src/applications/diffusion/ssh/DiffusionMercurialWireClientSSHProtocolChannel.php

Add a couple of clarifying comments to the Mercurial protocol parserClosedPublicActions