Differential D18836

Prevent hiding the PhabricatorProjectDetailsProfileMenuItem
ClosedPublic
Actions

Authored by 20after4 on Dec 22 2017, 3:24 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPbd5aa0c90fd1: Prevent hiding the PhabricatorProjectDetailsProfileMenuItem

Summary

This probably isn't the best solution, however, it conveniently avoids the bug from T13033. It would probably be more user-friendly (but more difficult to implement) if we allowed either Project Details or Workboard to be hidden but not both.

Test Plan

Tested locally, indeed this prevents hiding the menu item.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

20after4 created this revision.Dec 22 2017, 3:24 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 22 2017, 3:24 PM

Harbormaster completed remote builds in B18969: Diff 45192.Dec 22 2017, 3:25 PM

20after4 requested review of this revision.Dec 22 2017, 3:25 PM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 22 2017, 3:25 PM

20after4 mentioned this in T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal.Dec 22 2017, 3:26 PM

I think this is reasonable, hiding this doesn't make a ton of sense to me given that you can make something else the default anyway. I'll look at fixing T13033 properly, too.

This revision is now accepted and ready to land.Dec 22 2017, 3:43 PM

epriestley mentioned this in D18843: Allow "Manage" to be the default menu item for projects.Dec 23 2017, 4:44 PM

epriestley mentioned this in rP84cf49387984: Allow "Manage" to be the default menu item for projects.Dec 23 2017, 7:37 PM