Page MenuHomePhabricator

Prevent hiding the PhabricatorProjectDetailsProfileMenuItem
ClosedPublic

Authored by 20after4 on Dec 22 2017, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 9:12 PM
Unknown Object (File)
Wed, May 1, 12:04 AM
Unknown Object (File)
Mon, Apr 29, 12:53 AM
Unknown Object (File)
Sat, Apr 27, 10:15 PM
Unknown Object (File)
Fri, Apr 19, 2:43 AM
Unknown Object (File)
Fri, Apr 19, 2:43 AM
Unknown Object (File)
Fri, Apr 19, 2:43 AM
Unknown Object (File)
Thu, Apr 11, 4:04 AM
Subscribers

Details

Summary

This probably isn't the best solution, however, it conveniently avoids the bug from T13033. It would probably be more user-friendly (but more difficult to implement) if we allowed either Project Details or Workboard to be hidden but not both.

Test Plan

Tested locally, indeed this prevents hiding the menu item.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18969
Build 25583: Run Core Tests
Build 25582: arc lint + arc unit

Event Timeline

I think this is reasonable, hiding this doesn't make a ton of sense to me given that you can make something else the default anyway. I'll look at fixing T13033 properly, too.

This revision is now accepted and ready to land.Dec 22 2017, 3:43 PM

(I'm just going to pull this since it works alongside D18843.)

This revision was automatically updated to reflect the committed changes.

@epriestley: Thanks! Hope you're having a great holiday weekend :)