Page MenuHomePhabricator
Differential D18833

Fix an issue where blame could fatal for unrecognized authors
ClosedPublic
Actions

Authored by epriestley on Dec 18 2017, 2:31 PM.
Tags
None
Referenced Files
F13209730: D18833.id.diff
Fri, May 17, 1:49 AM
F13209121: D18833.diff
Thu, May 16, 9:54 PM
F13195331: D18833.diff
Sun, May 12, 10:18 PM
F13186995: D18833.diff
Sat, May 11, 4:15 AM
Unknown Object (File)
Tue, May 7, 7:20 AM
Unknown Object (File)
Fri, May 3, 5:56 AM
Unknown Object (File)
Thu, May 2, 11:20 AM
Unknown Object (File)
Thu, Apr 25, 12:59 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by janitorial.

Details

Reviewers
amckinley
Commits
rP563d42d40e15: (stable) Fix an issue where blame could fatal for unrecognized authors
rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors
Summary

See PHI255. See https://discourse.phabricator-community.org/t/error-generating-blame-data/766.

Test Plan
  • Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
  • Enabled blame.
  • Before patch: blame failed, fatal in logs.
  • After patch: blame worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
14 lines

Diff 45189

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility