Page MenuHomePhabricator
Differential D18833

Fix an issue where blame could fatal for unrecognized authors
ClosedPublic
Actions

Authored by epriestley on Dec 18 2017, 2:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:59 AM
Unknown Object (File)
Fri, Apr 19, 7:02 PM
Unknown Object (File)
Tue, Apr 16, 8:52 PM
Unknown Object (File)
Tue, Apr 16, 8:52 PM
Unknown Object (File)
Sat, Apr 13, 6:32 AM
Unknown Object (File)
Sat, Apr 13, 2:53 AM
Unknown Object (File)
Thu, Apr 11, 8:44 AM
Unknown Object (File)
Tue, Apr 9, 8:09 PM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by janitorial.

Details

Reviewers
amckinley
Commits
rP563d42d40e15: (stable) Fix an issue where blame could fatal for unrecognized authors
rPe411d75964e5: Fix an issue where blame could fatal for unrecognized authors
Summary

See PHI255. See https://discourse.phabricator-community.org/t/error-generating-blame-data/766.

Test Plan
  • Viewed a file contributed to by users with no Phabricator user accounts, in Diffusion.
  • Enabled blame.
  • Before patch: blame failed, fatal in logs.
  • After patch: blame worked.

Diff Detail

Repository
rP Phabricator
Branch
blame1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18953
Build 25564: Run Core Tests
Build 25563: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
14 lines

Diff 45178

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility