Add a Herald pre-commit field for detecting LFS usage
ClosedPublic
Actions

Authored by epriestley on Dec 13 2017, 1:59 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T7789: Support Git Large File Storage

Commits

rP8e416474c063: Add a Herald pre-commit field for detecting LFS usage

Summary

Depends on D18825. Ref T7789. See PHI131. Allows installs to selectively disable LFS by adding Herald rules to block commits that use LFS.

Test Plan

Wrote an LFS rule ("When commit uses git lfs, block commit").
Pushed an LFS commit: rejected.
Pushed a non-lFS commit: success.

Diff Detail

Repository

rP Phabricator

Branch

lfs2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18944
Build 25548: Run Core Tests
Build 25547: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 13 2017, 1:59 PM

Harbormaster completed remote builds in B18944: Diff 45171.Dec 13 2017, 2:00 PM

epriestley requested review of this revision.Dec 13 2017, 2:00 PM

epriestley added a child revision: D18828: Restore the "Download from Git LFS" UI button to Diffusion.Dec 13 2017, 2:04 PM

amckinley accepted this revision.Dec 14 2017, 5:50 PM

This revision is now accepted and ready to land.Dec 14 2017, 5:50 PM

epriestley mentioned this in T8644: Herald template / recipe book / examples / quick-create tool.Dec 18 2017, 4:32 PM

epriestley mentioned this in T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default.Dec 18 2017, 4:45 PM

Closed by commit rP8e416474c063: Add a Herald pre-commit field for detecting LFS usage (authored by epriestley). · Explain WhyDec 18 2017, 5:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

herald/

DiffusionPreCommitUsesGitLFSHeraldField.php

41 lines

Diff 45171

View Options

src/__phutil_library_map__.php