Page MenuHomePhabricator
Differential D18807

Make "arc land" prompt on "Changes Planned" revisions more explicit
ClosedPublic
Actions

Authored by epriestley on Nov 30 2017, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 9:52 AM
Unknown Object (File)
Thu, Dec 5, 9:34 AM
Unknown Object (File)
Tue, Dec 3, 7:10 PM
Unknown Object (File)
Nov 29 2024, 12:24 PM
Unknown Object (File)
Nov 29 2024, 11:10 AM
Unknown Object (File)
Nov 25 2024, 8:41 PM
Unknown Object (File)
Nov 25 2024, 2:40 PM
Unknown Object (File)
Nov 25 2024, 6:50 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T10233: arc error message unclear for accepted revision in "plan change" state
Commits
rARCa3519b8fdefc: (stable) Promote 2017 Week 48
rARCf4c80a114d36: Make "arc land" prompt on "Changes Planned" revisions more explicit
Summary

Fixes T10233. See PHI231. Users sometimes believe this warning is a bug and/or don't understand how they're supposed to resolve it.

Test Plan

Ran arc land on a revision in "Changes Planned", got a sensible prompt. Ran arc land on a revision in another non-accepted state, got more or less the old prompt.

Diff Detail

Repository
rARC Arcanist
Branch
lprompt1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18897
Build 25479: Run Core Tests
Build 25478: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 30 2017, 3:53 PM
Harbormaster completed remote builds in B18896: Diff 45122.Nov 30 2017, 3:54 PM
epriestley requested review of this revision.Nov 30 2017, 3:54 PM
epriestley planned changes to this revision.Nov 30 2017, 3:55 PM

(Actually executing my test plan.)

epriestley updated this revision to Diff 45123.Nov 30 2017, 3:59 PM
  • Fix newline escaping, increase drama.

Screen Shot 2017-11-30 at 7.59.18 AM.png (419×765 px, 82 KB)

Harbormaster completed remote builds in B18897: Diff 45123.Nov 30 2017, 4:00 PM
epriestley updated this revision to Diff 45124.Nov 30 2017, 4:00 PM

Existing prompt seems fine too:

Screen Shot 2017-11-30 at 8.00.17 AM.png (327×728 px, 66 KB)

Harbormaster completed remote builds in B18898: Diff 45124.Nov 30 2017, 4:01 PM
amckinley accepted this revision.Nov 30 2017, 6:58 PM
This revision is now accepted and ready to land.Nov 30 2017, 6:58 PM
epriestley planned changes to this revision.Nov 30 2017, 7:04 PM

I'm going to land this from the wrong state after deploying D18808 to double check that change.

This revision was not accepted when it landed; it landed in state Changes Planned.Nov 30 2017, 9:51 PM
Closed by commit rARCf4c80a114d36: Make "arc land" prompt on "Changes Planned" revisions more explicit (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Nov 30 2017, 9:52 PM

Looks like that worked.

Revision Contents
Changeset List

PathSize
src/
workflow/
41 lines

Diff 45123

View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
Phabricator · Built by Phacility